numericPrecision option added to pws-current files #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add option for numericPrecision param in API.
Add option for numericPrecision param in API.
|
@jimison - this patch looks great. Thank you! I'm testing it. Re-reading the docs at https://ibm.co/v2PWSCC What is your use case for extra precision? |
Valid Parameter Definitions
|
|
I'm comparing temperatures from various sources, including RPi's and
DB18S20 sensors (https://datasheets.maximintegrated.com/en/ds/DS18S20.pdf)
for actionable events and notifications. I want the extra precision as long
as there's not a polling time trade-off. This API is super handy since my
Weather Station posts updates every 5 seconds.
…On Mon, Mar 28, 2022 at 9:53 AM John Walicki ***@***.***> wrote:
@jimison <https://github.com/jimison> - this patch looks great. Thank you!
I'm testing it. Re-reading the docs at https://ibm.co/v2PWSCC
What is your use case for extra precision?
—
Reply to this email directly, view it on GitHub
<#10 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEVUISTSD7MU552GDE5UD23VCHIXTANCNFSM5RZPWUMQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Without With |
|
Thanks for reading the TWC docs and adding this optional parameter. |
|
@jimison - I am testing v0.5.0 before I |
|
I've got a fix. |
|
node-red-contrib-twc-weather:0.5.0 is available on npm |
|
Up and running. 😎
…On Mon, Mar 28, 2022 at 12:29 PM John Walicki ***@***.***> wrote:
node-red-contrib-twc-weather:0.5.0 is available on npm
- https://flows.nodered.org/node/node-red-contrib-twc-weather
- https://www.npmjs.com/package/node-red-contrib-twc-weather
—
Reply to this email directly, view it on GitHub
<#10 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEVUISRNJ2SWRCZGSRKMBHLVCH3BXANCNFSM5RZPWUMQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per issue #8, added numericPrecision option to allow decimal results for various values returned by the API request.